Replace a number of default argument values with "..." #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytype apparently doesn't like default values that aren't ints or None/True/False.
gvanrossum
approved these changes
May 21, 2017
|
Yes, I made sure to only remove = None for Optional arguments. In the future I'll do a pass of replacing |
li-dan
pushed a commit
to li-dan/typeshed
that referenced
this pull request
May 22, 2017
pytype apparently doesn't like default values that aren't ints or None/True/False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytype apparently doesn't like default values that aren't ints or
None/True/False.