Bundle path handling in ts_utils.paths #12805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use relative paths, which allows running scripts in any working directory.
lib/ts_utils/paths.py
Outdated
| from pathlib import Path | ||
| from typing import Final | ||
|
|
||
| TS_BASE_PATH: Final = Path(__file__).parent.parent.parent.relative_to(Path.cwd(), walk_up=True) |
There was a problem hiding this comment.
walk_up=True is new in 3.12; it might be too early to require 3.12 here?
I think an alternative would be:
Suggested change
| TS_BASE_PATH: Final = Path(__file__).parent.parent.parent.relative_to(Path.cwd(), walk_up=True) | |
| TS_BASE_PATH: Final = Path(__file__).parent.parent.parent.resolve().relative_to(Path.cwd()) |
There was a problem hiding this comment.
resolve() won't help as Path(__file__) is already absolute. I'll just skip the walk_up on Python < 3.12. This means, it's not possible to run the scripts from sub-directories, but that's the status quo anyway.
|
I guess that using |
|
I've used non-relative paths for now. I still think it makes sense to bundle all path handling in one file and we are prepared for relative paths once we solve the problem of determining where the typeshed directory lives. |
JelleZijlstra
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use relative paths, which allows running scripts in any working directory.