Skip to content

distutils: Add some return types for setuptools to pass ANN201 #12841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Oct 17, 2024

I'm working on providing distutils stubs directly from setuptools (for Python 3.12+ support). And I wanted to start from as clean a slate as possible when copying typeshed's stubs.

I'm providing back the changes that were needed to pass Ruff's ANN201 as configured on setuptool's side.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these types look reasonable; I didn't verify them against the source though.

@srittau srittau merged commit 8113832 into python:main Oct 18, 2024
65 checks passed
@Avasam Avasam deleted the complete-some-distutils-annotations-for-setuptools-vendoring branch October 18, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants