Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use Python 3.12 for third-party stubtest #12847

Closed
wants to merge 14 commits into from
Closed

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Oct 18, 2024

No description provided.

@srittau
Copy link
Collaborator Author

srittau commented Oct 18, 2024

  • atheris doesn't compile (last release 2023-08)
  • boto fails to import boto.vendored.six (last release 2018-07!) (Remove boto #12848)
  • openpyxl needs a stubtest allowlist update
  • playsound doesn't compile (last release 2021-07)
  • requests needs a stubtest allowlist update
  • gdb fails with the following traceback???
Traceback (most recent call last):
  File "/tmp/stubtest-j8_r64qv/gdb_stubtest.py", line 22, in <module>
    from mypy.stubtest import main
  File "/tmp/stubtest-j8_r64qv/lib/python3.12/site-packages/mypy/stubtest.py", line 30, in <module>
    from pathlib import Path
  File "/usr/lib/python3.12/pathlib.py", line 19, in <module>
    from urllib.parse import quote_from_bytes as urlquote_from_bytes
  File "/usr/lib/python3.12/urllib/parse.py", line 36, in <module>
    import math
ModuleNotFoundError: No module named 'math'

@srittau
Copy link
Collaborator Author

srittau commented Oct 21, 2024

I'm honestly stumped why gdb fails. Locally (also using Ubuntu 2024.04), this works.

@AlexWaygood
Copy link
Member

There's also a couple of stubtest failures on wtforms still

@srittau srittau marked this pull request as ready for review December 3, 2024 14:42
# from urllib.parse import quote_from_bytes as urlquote_from_bytes
# File "/usr/lib/python3.12/urllib/parse.py", line 36, in <module>
# import math
# ModuleNotFoundError: No module named 'math'
Copy link
Collaborator

@Avasam Avasam Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From all the googling I did. This seems to always come back to a python build/installation issue. I know we do a bit a special setup to run stubtest on gdb. Maybe there's something wrong with the Python 3.12 version from actions/setup-python. We could raise an issue / request support if we can provide an MRE"

Anyway with #13582 being merge this is already skipped, so I wouldn't consider it a blocker anymore. You can probably merge both comments.

@Avasam
Copy link
Collaborator

Avasam commented Mar 6, 2025

Other than different comments, I think this may have been superseded by #13582 ?

@srittau srittau closed this Mar 6, 2025
@srittau srittau deleted the py-3.12-third-party branch March 6, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants