Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove playsound stubs #12857

Merged
merged 3 commits into from
Oct 19, 2024
Merged

Remove playsound stubs #12857

merged 3 commits into from
Oct 19, 2024

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Oct 19, 2024 •
edited by AlexWaygood
Loading

Closes: #12850

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@srittau
Copy link
Collaborator Author

srittau commented Oct 19, 2024

CI failure unrelated: typeshed-internal/stub_uploader#149

@srittau
Copy link
Collaborator Author

srittau commented Oct 19, 2024

Missed a step, marking as draft.

@srittau srittau marked this pull request as draft October 19, 2024 15:31
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@srittau
Copy link
Collaborator Author

srittau commented Oct 19, 2024

Uploaded: https://pypi.org/project/types-playsound/

@srittau srittau marked this pull request as ready for review October 19, 2024 15:42
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit d1c1675 into python:main Oct 19, 2024
47 checks passed
@srittau srittau deleted the rm-playsound branch October 19, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove playsound
2 participants
@srittau @AlexWaygood