Skip to content

Sample text for closing future stdlib PRs #13697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2025
Merged

Sample text for closing future stdlib PRs #13697

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4c1f075
Sample text for closing future stdlib PRs
srittau Mar 21, 2025
db40f18
Link to CONTRIBUTING in text
srittau Mar 21, 2025
22682e2
Move onto one line for easier c&p
srittau Mar 21, 2025
bc81def
Move onto one line for easier c&p
srittau Mar 21, 2025
0ab92bc
Fixes from PR reviews
srittau Mar 21, 2025
e2bfe74
Switch alternatives for reopening around
srittau Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions MAINTAINERS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,13 @@ blocker is, usually with a link to an open issue in another project.
We want to maintain a welcoming atmosphere for contributors, so use a friendly
message when closing the PR. Example message:

Thanks for contributing! I'm closing this PR for now, because it still
<fails some tests OR has unresolved review feedback OR has a merge conflict>
after three months of inactivity. If you are still interested, please feel free to open
a new PR (or ping us to reopen this one).
Thanks for contributing! I'm closing this PR for now, because it still <fails some tests OR has unresolved review feedback OR has a merge conflict> after three months of inactivity. If you are still interested, please feel free to open a new PR (or ping us to reopen this one).

### Closing PRs for future standard library changes

*See also the [guidelines in the CONTRIBUTING file](./CONTRIBUTING.md#standard-library-stubs).*

When rejecting a PR for a change for a future Python version, use a message
like:

Thanks for contributing! Unfortunately, [as outlined in our CONTRIBUTING document](https://github.com/python/typeshed/blob/main/CONTRIBUTING.md#standard-library-stubs) we only accept pull requests to the standard library for future Python versions after the first beta version has been released. This is in part to prevent churn in the stubs, and in part because the testing infrastructure for the future version is not yet in place. Please feel free to open a new PR when the first beta version has been released. Alternatively, if this PR is still relevant, you can leave a comment here to reopen it.