Skip to content

Update Num stub for typed_ast 2.7 #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2017
Merged

Update Num stub for typed_ast 2.7 #1430

merged 1 commit into from
Jun 23, 2017

Conversation

ilinum
Copy link
Contributor

@ilinum ilinum commented Jun 23, 2017

Field n should be a Union[int, float, complex], not just Union[int, float].

@ilinum
Update Num stub for typed_ast 2.7
5da12bb 
Field `n` should be a `Union[int, float, complex]`, not just `Union[int, float]`
@ilinum
Copy link
Contributor Author

ilinum commented Jun 23, 2017

This was causing some code within mypy to not be typechecked because mypy did not realize that Num.n could be of type complex

@JelleZijlstra
Copy link
Member

Was this found by your implicit Any work? Nice.

@JelleZijlstra JelleZijlstra merged commit ee5e3af into python:master Jun 23, 2017
@ilinum ilinum deleted the typedast_num branch June 23, 2017 23:45
@ilinum
Copy link
Contributor Author

ilinum commented Jun 23, 2017

@JelleZijlstra in a way - I am updating html-report to highlight dead code as Any( python/mypy#2785), so I found some dead code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilinum @JelleZijlstra