Work around mypy issue #4554 in attr.Factory #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the following not give a type error: y: DefaultDict[str, List[int]] = Factory(lambda: defaultdict(list))
|
@chadrik Another change for you. :) |
third_party/2and3/attr/__init__.pyi
Outdated
| def Factory(factory: Union[Callable[[], _T], Callable[[Any], _T]], takes_self: bool = ...) -> _T: ... | ||
| # Work around mypy issue #4554 by using an overload vs a Union. | ||
| @overload | ||
| def Factory(factory: Callable[[], _T]) -> _T: ... |
There was a problem hiding this comment.
Isn't this equivalent to the second overload? If not why, don't you need one where the Callable takes an argument and the second argument is omitted?
There was a problem hiding this comment.
If you don't set takes_self then you'd better not send in a function with an argument (because the default value is False). If you do set takes_self then both are allowed.
That being said I'm ok with switching this to:
@overload
def Factory(factory: Callable[[], _T], takes_self: bool = ...) -> _T: ...
@overload
def Factory(factory: Callable[[Any], _T], takes_self: bool = ...) -> _T: ...
And forget about the first overload.
There was a problem hiding this comment.
Yes, the first overload is redundant because the argument has a default.
|
First overload removed. |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
This makes the following not give a type error: y: DefaultDict[str, List[int]] = Factory(lambda: defaultdict(list))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the following not give a type error because of python/mypy#4554