try using --no-site-packages
#2036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the flag should be added to |
|
If #2037 passes let's use that. |
emmatyping
reviewed
Apr 9, 2018
| @@ -131,6 +131,7 @@ def main(): | |||
| runs += 1 | |||
| flags = ['--python-version', '%d.%d' % (major, minor)] | |||
| flags.append('--strict-optional') | |||
| flags.append('--no-site-packages') | |||
There was a problem hiding this comment.
Perhaps this should be gated by Python version?
There was a problem hiding this comment.
Do you mean that we should do this only for Python versions for which we don't have a binary? I don't think that's worth it, since for typeshed's purposes we don't want to look at site-packages in any case. Actually, our CI might get confused when PEP 561-enabled packages start showing up in the venv we use to run tests.
There was a problem hiding this comment.
Fair point. I think this change LGTM then.
emmatyping
approved these changes
Apr 9, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2035.