Skip to content

Conversation

@ymyzk
Copy link
Contributor

@ymyzk ymyzk commented Jun 11, 2018

Add a new stub for nis module. (Python 3 docs / Python 2 docs)

@@ -0,0 +1,11 @@
# Stubs for nis (Python 3.6)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first line is not very useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I remove this line.

@@ -0,0 +1,11 @@
# Stubs for nis (Python 3.6)
# Unix only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment could be replaced by wrapping the rest of the code in

if sys.platform != 'win32':

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your good advice!

@gvanrossum gvanrossum merged commit 46a59fc into python:master Jun 11, 2018
@ymyzk ymyzk deleted the nis branch June 24, 2018 08:20
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants