Don't accept new third party stubs anymore #2441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
commented
Sep 11, 2018
CONTRIBUTING.md
Outdated
| If you wish typeshed maintainers to review your third party stubs, | ||
| please [open a new issue](https://github.com/python/typeshed/issues/new) | ||
| in the typeshed repository with a link to the GitHub pull request | ||
| you wish be have reviewed. |
There was a problem hiding this comment.
This text asks for GitHub PRs for review requests. Should we broaden this or do you think it is okay to be this specific?
There was a problem hiding this comment.
I'd rather just say "to the code you would like us to review". No need to be overly specific. We should perhaps clarify though that there is no guarantee that we'll review their code quickly (or at all), since we're all volunteers.
srittau
commented
Sep 11, 2018
| third party package or distributed as a separate package. See | ||
| [PEP 561](https://www.python.org/dev/peps/pep-0561/) for details. | ||
|
|
||
| When creating a separate package, you should |
There was a problem hiding this comment.
Since we can't really control what happens outside of typeshed, I have softened the "need to" from the original text to a "should" here.
|
Closing in favor of #2491. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2440