Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add encoding attribute to Py2 sys.stdout #3084

Closed
wants to merge 1 commit into from

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Jun 22, 2019

Fixes #2196

@JelleZijlstra
Copy link
Member

As @gvanrossum said in the linked issue, this would break any code trying to assign the result of an open() call to sys.stdout.

Also, stderr, stdout, and stdin are all the same type; it doesn't make sense to use a special type just for stdout.

@JelleZijlstra
Copy link
Member

Closing since I don't think this change as it stands is an improvement.

@gvanrossum
Copy link
Member

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sys.stdout missing encoding attribute in Python 2
3 participants