TypedDict: fix keys, values, items return value #3529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You have a CI failure, because there is a mypy test that asserted the old type. Could you submit a PR to mypy that fixes that test? Then I should be able to merge the mypy and typeshed PRs and get everything green again. |
JelleZijlstra
approved these changes
Dec 7, 2019
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Dec 8, 2019
The signature of TypedDict's keys, values, items will be updated in typeshed in: python/typeshed#3529 The relevant issue is: python/typeshed#3473
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Dec 8, 2019
The signature of TypedDict's keys, values, items will be updated in typeshed in: python/typeshed#3529 The relevant issue is: python/typeshed#3473 That PR fails testTypedDictMappingMethods https://travis-ci.org/python/typeshed/builds/621439570 Tested by using my patched version of typeshed: ln -sf ~/typeshed mypy/typeshed pytest -n0 -k testTypedDictMappingMethods
JelleZijlstra
pushed a commit
to python/mypy
that referenced
this pull request
Mar 14, 2020
The signature of TypedDict's keys, values, items will be updated in typeshed in: python/typeshed#3529 The relevant issue is: python/typeshed#3473 That PR fails testTypedDictMappingMethods https://travis-ci.org/python/typeshed/builds/621439570 Tested by using my patched version of typeshed: ln -sf ~/typeshed mypy/typeshed pytest -n0 -k testTypedDictMappingMethods Co-authored-by: hauntsaninja <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3473