Skip to content

Enable --disallow-subclassing-any #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/mypy_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ def main():
flags.append('--show-traceback')
flags.append('--no-implicit-optional')
flags.append('--disallow-any-generics')
flags.append('--disallow-subclassing-any')
if args.warn_unused_ignores:
flags.append('--warn-unused-ignores')
if args.platform:
Expand Down
2 changes: 1 addition & 1 deletion third_party/2/fb303/FacebookService.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class Client(Iface):
def shutdown(self): ...
def send_shutdown(self): ...

class Processor(Iface, TProcessor):
class Processor(Iface, TProcessor): # type: ignore
def __init__(self, handler) -> None: ...
def process(self, iprot, oprot): ...
def process_getName(self, seqid, iprot, oprot): ...
Expand Down
2 changes: 1 addition & 1 deletion third_party/2/scribe/scribe.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class Client(fb303.FacebookService.Client, Iface):
def send_Log(self, messages): ...
def recv_Log(self): ...

class Processor(fb303.FacebookService.Processor, Iface, TProcessor):
class Processor(fb303.FacebookService.Processor, Iface, TProcessor): # type: ignore
def __init__(self, handler) -> None: ...
def process(self, iprot, oprot): ...
def process_Log(self, seqid, iprot, oprot): ...
Expand Down
3 changes: 2 additions & 1 deletion third_party/2and3/google/protobuf/internal/containers.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ class RepeatedCompositeFieldContainer(BaseContainer[_T]):
def __eq__(self, other: object) -> bool: ...

# Classes not yet typed
class Mapping(Any): ...
class Mapping(object):
def __getattr__(self, name: str) -> Any: ... # incomplete
class MutableMapping(Mapping): ...
class ScalarMap(MutableMapping): ...
class MessageMap(MutableMapping): ...