Adding Protocol _Mapping for format_map method #3877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class _SupportsIndex(Protocol): | ||
| def __index__(self) -> int: ... | ||
|
|
||
| def runtime_checkable(cls: _TC) -> _TC: ... |
There was a problem hiding this comment.
Why are you adding this (and Collections) to builtins? They don't exist in builtins at runtime.
There was a problem hiding this comment.
Thanks for correcting, I wasn't sure about this, the original stubs for Mapping had those if I just use Protocol[_KT, _VT_co] it keeps saying Invariant type variable '_KT' used in protocol where contravariant one is expected.
There was a problem hiding this comment.
Well if nothing else they should be imported from typing.
|
I provided a simpler solution in #4122. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3824