Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msilib and _msi to stubtest whitelist #3939

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Apr 23, 2020

Fixes the build failures on master.

@srittau srittau requested a review from JelleZijlstra April 23, 2020 10:20
@srittau
Copy link
Collaborator Author

srittau commented Apr 23, 2020

@hauntsaninja I can't request you as reviewer, so I'll do it here.

@@ -573,6 +570,13 @@ zipfile.ZipExtFile.read
zipfile.ZipExtFile.readline
zlib.compressobj

# Modules that do not exist on Linux systems and cannot be checked by our CI process.
Copy link
Collaborator

@hauntsaninja hauntsaninja Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd move this below the "Whitelist entries that cannot or should not be fixed" header.

Additionally, if we're looking to try to minimise "unused whitelist entry" errors if someone attempts to run stubtest_test.py on Windows locally, we might want to modify the list as follows, using the method described in python/mypy#8502 (comment) to allow these entries to go unused:

(_msi)?
(_winapi)?
(msilib(\.[a-z]+)?)?
(msvcrt)?
(winsound)?

Make win modules optional
@JelleZijlstra JelleZijlstra merged commit 733c558 into master Apr 24, 2020
@JelleZijlstra JelleZijlstra deleted the msilib-stubtest branch April 24, 2020 02:09
grievejia pushed a commit to grievejia/typeshed that referenced this pull request Apr 24, 2020
* Add msilib and _msi to stubtest whitelist

* Group Windows-only modules

* Move win modules to bottom

Make win modules optional
vishalkuo pushed a commit to vishalkuo/typeshed that referenced this pull request Jun 26, 2020
* Add msilib and _msi to stubtest whitelist

* Group Windows-only modules

* Move win modules to bottom

Make win modules optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants