-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Added missing type annotations for fractions and numbers modules. #4401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f37062d
Added missing type annotations for fractions and numbers modules.
msfterictraut a2c18e6
Fixed bad annotation for self.
msfterictraut 48513a8
Worked around error emitted by mypy.
msfterictraut 86f5ea5
Fixed another issue found in CI test.
msfterictraut 23fa7d5
Removed extra line at bottom of file that my auto-formatter keeps add…
msfterictraut f7d16ab
Incorporated code review feedback. Did a bunch of experimentation wit…
msfterictraut c90aa22
Adjusted base class abstract method signatures.
msfterictraut 52a2353
Fixed error caught by test.
msfterictraut 596edbd
Removed unnecessary overload.
msfterictraut c1b7f4a
Fixed error in __round__ identified by stubtest.
msfterictraut ad863f7
Made changes based on PR feedback.
msfterictraut 911e8f9
Fixed overload ordering issue
msfterictraut 1f280ca
Fixed more stubtest errors
msfterictraut 55755f6
Missed one more overload order issue
msfterictraut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.