add keyword #446
add keyword #446
Conversation
|
|
||
| from typing import Sequence | ||
|
|
||
| def iskeyword(s: str) -> bool: ... |
There was a problem hiding this comment.
This also works on bytes, Tuple[str], Tuple[bytes], frozenset[str], etc.
We could use something like Iterable[Union[Text, bytes]], but it also needs to be hashable.
Maybe just Union[Text, bytes] is good enough.
There was a problem hiding this comment.
Correct, it works on every Hashable, but I'm unable to find a concret example where it would be correct to test that a frozenset is a keyword, it would be better to trigger a warning.
In CPython implementation, the code is simply
iskeyword = frozenset(kwlist).__contains__I don't think that was intended to handle testing other type of value, it works, but that's not the point.
There was a problem hiding this comment.
Agreed. But we should at least allow unicode (on Python 2) and bytes (on Python 3).
|
According to #439, it would be better to use |
|
Ho, okay, using it then. |
I just found the most trivial python module.
https://docs.python.org/3/library/keyword.html