concurrent.futures: update for py39, minor fixes #4503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 30, 2020 15:26
Note the new parameter doesn't actually exist on the base class, even though it's documented as that being the case. Asked about it in https://bugs.python.org/issue39349
srittau
reviewed
Aug 31, 2020
| @@ -46,14 +46,17 @@ class Future(Generic[_T]): | |||
| def set_exception_info(self, exception: Any, traceback: Optional[TracebackType]) -> None: ... | |||
|
|
|||
| class Executor: | |||
| def submit(self, fn: Callable[..., _T], *args: Any, **kwargs: Any) -> Future[_T]: ... | |||
| def submit(self, __fn: Callable[..., _T], *args: Any, **kwargs: Any) -> Future[_T]: ... | |||
There was a problem hiding this comment.
I don't think that changing it to a positional-only argument is correct, at least not without a version check. In 3.8.5, there is an explicit check for a fn argument. While a warning is generated, it is accepted. Of course, it's a bit weird, since the checking code is within an abstract method, so it will likely never get executed.
There was a problem hiding this comment.
Good catch, weird the documentation doesn't mentioned the break in backwards compatibility. The concrete classes do do similar checks. I'll make an exception to #3693 here
srittau
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the new parameter doesn't actually exist on the base class, even
though it's documented as that being the case. Asked about it in https://bugs.python.org/issue39349