Skip to content

mypy_primer: post failures as comments #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

hauntsaninja
Copy link
Collaborator

No description provided.

@hauntsaninja hauntsaninja force-pushed the diff branch 5 times, most recently from ac67e68 to 0a1594d Compare October 14, 2020 23:24
@srittau
Copy link
Collaborator

srittau commented Oct 15, 2020

Good idea!

@JelleZijlstra
Copy link
Member

Somebody on the Black repo (psf/black#1764) suggested using "GitHub Annotations", which seem like they serve a similar purpose. I can't find a lot of documentation for that feature though.

@hauntsaninja
Copy link
Collaborator Author

The thing that's blocking this is that the pull_request event doesn't give you a token with write permissions, so the API call to comment fails.
It looks like Github recently added a way around this: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
But a) it means that this is much harder to test, b) I think some of the Github variables might change values, so would need to make sure the cloning / checking out logic in mypy_primer continues to work. All in all, a little painful — if someone else wants to pick this up, please do!

I think what Jelle is mentioning is https://docs.github.com/en/free-pro-team@latest/rest/reference/checks#create-a-check-run. I'll take a look, might be a better fit.

@hauntsaninja
Copy link
Collaborator Author

It looks like this just worked once it was merged, so maybe that's what needs to happen here: hauntsaninja#1 (comment)

@hauntsaninja hauntsaninja marked this pull request as ready for review October 26, 2020 03:41
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this.

@srittau srittau merged commit 1bd808a into python:master Oct 26, 2020
@hauntsaninja hauntsaninja deleted the diff branch October 26, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants