Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overload to cast for objects #4851

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Add overload to cast for objects #4851

merged 1 commit into from
Dec 28, 2020

Conversation

septatrix
Copy link
Contributor

No description provided.

@septatrix septatrix changed the title Add overload to cast for objects (#4810) Add overload to cast for objects Dec 26, 2020
@septatrix
Copy link
Contributor Author

Fixes #4810

hauntsaninja
hauntsaninja approved these changes Dec 28, 2020
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This seems fine, but may change depending on where python/mypy#9773 ends up. In practice type checkers special case cast, so not sure that this has much practical effect.

@hauntsaninja hauntsaninja merged commit a3c9392 into python:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@septatrix @hauntsaninja