Fix incorrectly Optional builtin function args #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many builtin functions were accidentally marked as Optional because they were given default values of None.
| @@ -608,7 +608,7 @@ class range(Sequence[int]): | |||
| @overload | |||
| def __init__(self, start: int, stop: int, step: int = 1) -> None: ... | |||
| def count(self, value: int) -> int: ... | |||
| def index(self, value: int, start: int = 0, stop: int = None) -> int: ... | |||
| def index(self, value: int) -> int: ... | |||
There was a problem hiding this comment.
This is the one change that isn't only making something non-Optional. In trying to test the third argument of range.index, I found that the function only takes one argument (in spite of help(range) suggesting otherwise).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many builtin functions were accidentally marked as Optional because
they were given default values of None.