Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any-> object in simple operator funcs #6451

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Conversation

AlexWaygood
Copy link
Member

No description provided.

@github-actions

This comment has been minimized.

@Akuli
Copy link
Collaborator

Akuli commented Nov 30, 2021

Can you do the same for not_ and truth? This could be done to several other functions too, but not_, truth, is_ and is_not are perhaps the simplest ones, least likely to cause any problems.

@AlexWaygood
Copy link
Member Author

Can you do the same for not_ and truth?

I was less sure about those than about these, because of the numpy weirdness around truth-testing. But I guess builtins.bool.__new__ is annotated as accepting object, and we should be consistent! I'll make the change.

@AlexWaygood AlexWaygood changed the title Any-> object in operator.is_ & operator.is_not Any-> object in simple operator funcs Nov 30, 2021
@AlexWaygood
Copy link
Member Author

Any idea why mypy_primer has suddenly started taking much longer in the last few days, btw?

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Nov 30, 2021

I finally got around to fixing project setups for the modular typeshed change, so now mypy_primer installs many more pip packages (mypy has more to do also pip isn't fast). I also added maybe 20 more projects.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
Copy link
Member Author

I finally got around to fixing project setups for the modular typeshed change, so now mypy_primer installs many more pip packages (and pip is really slow). I also added maybe 20 more projects.

Ahh, makes sense, thanks!

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Nov 30, 2021

Recent changes visible like so: https://github.com/hauntsaninja/mypy_primer/compare/35e004c92..master

@hauntsaninja
Copy link
Collaborator

I'm hopeful mypy 0.920, if it's ever released, will make mypy-primer much faster (e.g. python/mypy#10922). Maybe I should switch typeshed to using a pre-release wheel... We could also just shard it more.

@AlexWaygood
Copy link
Member Author

...if it's ever released

👀

@AlexWaygood
Copy link
Member Author

I'm hopeful mypy 0.920, if it's ever released, will make mypy-primer much faster

Definitely important to have a more comprehensive diff in the meantime, anyway! Thanks for all the work you do maintaining such an awesome tool 🙂

@Akuli Akuli merged commit 1f62ff6 into python:master Nov 30, 2021
@AlexWaygood AlexWaygood deleted the patch-2 branch November 30, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants