Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add execution_options to Session.get() #6656

Merged
merged 5 commits into from
Dec 23, 2021
Merged

Add execution_options to Session.get() #6656

merged 5 commits into from
Dec 23, 2021

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Dec 22, 2021 •
edited
Loading

Also use builtin.type instead of typing.Type

@srittau srittau marked this pull request as draft December 22, 2021 08:15
@srittau
Copy link
Collaborator Author

srittau commented Dec 22, 2021

Example for #4820. Leaving open for now for experiments.

@srittau
Update to mypy 0.921
abe63e7 
Test third-party stubs with typeshed from mypy
@srittau srittau closed this Dec 22, 2021
@srittau srittau reopened this Dec 22, 2021
@srittau
Copy link
Collaborator Author

srittau commented Dec 22, 2021

This looks much better. We need to fix the stubtest warnings, but should do that outside this PR.

@srittau
Copy link
Collaborator Author

srittau commented Dec 23, 2021

1.4.29 was released a few hours ago, so I assume the new stubtest errors are due to that. Will have a look later.

@srittau srittau marked this pull request as ready for review December 23, 2021 10:02
@srittau srittau changed the title Use builtin.type instead of typing.Type Add execution_options to Session.get() Dec 23, 2021
Akuli
Akuli approved these changes Dec 23, 2021
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

execution_options seems to be a dict, but it isn't clear to me what mapping protocol would make sense the most for this, and Any is much better than a missing argument.

@Akuli Akuli merged commit aa329b2 into python:master Dec 23, 2021
@srittau srittau deleted the sqlalchemy-type branch December 23, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srittau @Akuli @JelleZijlstra