Make os.path.join() first parameter pos-only
#6812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Jan 4, 2022
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Sounds like a good idea.
AlexWaygood
added a commit
to AlexWaygood/mypy
that referenced
this pull request
Jan 5, 2022
As discussed in python#11895, mypy's test suite currently does not pass a mypy self-check when run on Windows. This should hopefully be fixed by python/typeshed#6812, but running a self-check on Windows as part of the CI tests should help avoid this issue in the future. This new CI test should hopefully fail until python#11905 is merged, confirming the diagnosis of the problem that I made in python#11895. Once python#11905 is merged, it should hopefully then pass, allowing this PR to be merged.
JelleZijlstra
pushed a commit
to python/mypy
that referenced
this pull request
Jan 28, 2022
As discussed in #11895, mypy's test suite currently does not pass a mypy self-check when run on Windows. This should hopefully be fixed by python/typeshed#6812, but running a self-check on Windows as part of the CI tests should help avoid this issue in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently surprised to find that the mypy test suite doesn't pass mypy when run on Windows. This is because
posixpath.join()andntpath.join()have different names for the first parameter.Given that both
posixpathandntpathare undocumented modules -- which only exist to provide platform-specific implementations for theos.pathmodule -- I think it makes sense to make the first parameter positional-only for both functions. The whole point of theos.pathmodule is that you can get path-related functions that will reliably work on all systems. That guarantee goes away if you use a keyword argument for the first parameter ofos.path.join().