Skip to content

bisect: fix type of x when key is present #7097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 8 commits into from
Feb 1, 2022
Merged

bisect: fix type of x when key is present #7097

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f45798c
bisect: fix type of x when key is present
Kentzo Feb 1, 2022
8e93f23
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 1, 2022
dc402c6
Fix missing import for overload
Kentzo Feb 1, 2022
d1d3a82
Fix missing import of SupportsRichComparison
Kentzo Feb 1, 2022
c15b3a9
Fix a typo
Kentzo Feb 1, 2022
f099253
Fix redundant import
Kentzo Feb 1, 2022
31db588
Fix stubtest errors
Kentzo Feb 1, 2022
867280c
Fix stubtest errors
Kentzo Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions stdlib/_bisect.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,53 @@
import sys
from _typeshed import SupportsRichComparison
from typing import Callable, MutableSequence, Sequence, TypeVar
from _typeshed import SupportsRichComparisonT
from typing import Callable, MutableSequence, Sequence, TypeVar, overload

_T = TypeVar("_T")

if sys.version_info >= (3, 10):
@overload
def bisect_left(a: Sequence[_T], x: _T, lo: int = ..., hi: int | None = ..., *, key: None = ...) -> int: ...
@overload
def bisect_left(
a: Sequence[_T], x: _T, lo: int = ..., hi: int | None = ..., *, key: Callable[[_T], SupportsRichComparison] | None = ...
a: Sequence[_T],
x: SupportsRichComparisonT,
lo: int = ...,
hi: int | None = ...,
*,
key: Callable[[_T], SupportsRichComparisonT] = ...,
) -> int: ...
@overload
def bisect_right(a: Sequence[_T], x: _T, lo: int = ..., hi: int | None = ..., *, key: None = ...) -> int: ...
@overload
def bisect_right(
a: Sequence[_T], x: _T, lo: int = ..., hi: int | None = ..., *, key: Callable[[_T], SupportsRichComparison] | None = ...
a: Sequence[_T],
x: SupportsRichComparisonT,
lo: int = ...,
hi: int | None = ...,
*,
key: Callable[[_T], SupportsRichComparisonT] = ...,
) -> int: ...
@overload
def insort_left(a: MutableSequence[_T], x: _T, lo: int = ..., hi: int | None = ..., *, key: None = ...) -> None: ...
@overload
def insort_left(
a: MutableSequence[_T],
x: _T,
x: SupportsRichComparisonT,
lo: int = ...,
hi: int | None = ...,
*,
key: Callable[[_T], SupportsRichComparison] | None = ...,
key: Callable[[_T], SupportsRichComparisonT] = ...,
) -> None: ...
@overload
def insort_right(a: MutableSequence[_T], x: _T, lo: int = ..., hi: int | None = ..., *, key: None = ...) -> None: ...
@overload
def insort_right(
a: MutableSequence[_T],
x: _T,
x: SupportsRichComparisonT,
lo: int = ...,
hi: int | None = ...,
*,
key: Callable[[_T], SupportsRichComparison] | None = ...,
key: Callable[[_T], SupportsRichComparisonT] = ...,
) -> None: ...

else:
Expand Down