Fix positional-only differences in sqlite3
#7222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
| def __getitem__(self, index): ... | ||
| def __gt__(self, other): ... | ||
| def __eq__(self, __other): ... | ||
| def __ge__(self, __other): ... |
There was a problem hiding this comment.
Arguably this shouldn't exist. The type defines the tp_richcompare slot, which I believe automatically gets mapped to all six Python-level dunders, but it always returns NotImplemented for anything other than EQ and NE. As a result, sorted(list[Row]) doesn't work, but a type checker will allow it. Anyway, that's a problem for another day.
JelleZijlstra
approved these changes
Feb 15, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.