Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove selenium stubs #8753

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Remove selenium stubs #8753

merged 1 commit into from
Sep 16, 2022

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Sep 16, 2022

Closes: #7381

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoosh, look at 'em go

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

bokeh (https://github.com/bokeh/bokeh)
- src/bokeh/io/webdriver.py:66: note: ... from here:
- src/bokeh/io/webdriver.py:66: note: In module imported here:
+ src/typings/selenium/webdriver/firefox/webdriver.pyi:1:1: error: Cannot find implementation or library stub for module named "selenium.webdriver.firefox.service"  [import]
+ src/typings/selenium/webdriver/firefox/webdriver.pyi: note: In member "__init__" of class "WebDriver":
+ src/typings/selenium/webdriver/firefox/webdriver.pyi:7:5: error: Argument 2 to "__init__" becomes "Optional[Any]" due to an unfollowed import  [no-any-unimported]
+ src/bokeh/io/webdriver.py:66:1: error: Cannot find implementation or library stub for module named "selenium.webdriver.firefox.service"  [import]
- src/bokeh/io/webdriver.py: note: In function "create_firefox_webdriver":
- src/bokeh/io/webdriver.py:69:15: error: Missing positional argument "executable_path" in call to "Service"  [call-arg]

@AlexWaygood
Copy link
Member

AlexWaygood commented Sep 16, 2022

Diff from mypy_primer, showing the effect of this PR on open source code:

bokeh (https://github.com/bokeh/bokeh)
- src/bokeh/io/webdriver.py:66: note: ... from here:
- src/bokeh/io/webdriver.py:66: note: In module imported here:
+ src/typings/selenium/webdriver/firefox/webdriver.pyi:1:1: error: Cannot find implementation or library stub for module named "selenium.webdriver.firefox.service"  [import]
+ src/typings/selenium/webdriver/firefox/webdriver.pyi: note: In member "__init__" of class "WebDriver":
+ src/typings/selenium/webdriver/firefox/webdriver.pyi:7:5: error: Argument 2 to "__init__" becomes "Optional[Any]" due to an unfollowed import  [no-any-unimported]
+ src/bokeh/io/webdriver.py:66:1: error: Cannot find implementation or library stub for module named "selenium.webdriver.firefox.service"  [import]
- src/bokeh/io/webdriver.py: note: In function "create_firefox_webdriver":
- src/bokeh/io/webdriver.py:69:15: error: Missing positional argument "executable_path" in call to "Service"  [call-arg]

I think this diff is just because mypy_primer doesn't install selenium before checking bokeh: https://github.com/hauntsaninja/mypy_primer/blob/master/mypy_primer.py#L1650

@AlexWaygood
Copy link
Member

(I've filed hauntsaninja/mypy_primer#44)

@srittau srittau merged commit 9b306c3 into python:master Sep 16, 2022
@srittau srittau deleted the rm-selenium branch September 16, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove selenium types (not before September 2022)
2 participants