-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix intransitive subtyping issue with SupportsGetItem #8785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intransitive subtyping issue with SupportsGetItem #8785
Conversation
This comment has been minimized.
This comment has been minimized.
... why is |
Maybe it once had a strict annotation for |
This comment has been minimized.
This comment has been minimized.
I guess it is pretty nice to say something's a |
It might be nice to add a comment to |
I did a spelunk, and it's always been this way. From before typeshed: |
We did simultaneous spelunking, I arrived at the same conclusion :-) |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
See python/mypy#13713 for details