Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-generated peewee stubs #8834

Merged
merged 6 commits into from
Oct 4, 2022
Merged

Add auto-generated peewee stubs #8834

merged 6 commits into from
Oct 4, 2022

Conversation

Akuli
Copy link
Collaborator

@Akuli Akuli commented Oct 3, 2022

#4776 has been open and inactive for a very long time now. I'm planning to copy parts of it into smaller, easily reviewable PRs later. Other contributors should feel free to do that too in case I get distracted :)

This PR contains the output of scripts/create_baseline_stubs.py and whatever is needed to make the CI pass.

@Akuli Akuli marked this pull request as draft October 3, 2022 22:33
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some obvious things to fix here (methods that are currently typed as attributes, etc.), but they can all be addressed in follow-up PRs :)

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Akuli Akuli marked this pull request as ready for review October 4, 2022 09:40
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 1cb5482 into python:master Oct 4, 2022
@Akuli Akuli deleted the peeweegen branch October 4, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants