Run stubtest on windows for colorama #9168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Avasam
changed the title
Akuli
reviewed
Nov 12, 2022
| @@ -25,6 +25,8 @@ if sys.platform == "win32": | |||
| def FillConsoleOutputCharacter(stream_id: int, char: str, length: int, start: COORD) -> int: ... | |||
| def FillConsoleOutputAttribute(stream_id: int, attr: int, length: int, start: COORD) -> wintypes.BOOL: ... | |||
| def SetConsoleTitle(title: str) -> wintypes.BOOL: ... | |||
| def GetConsoleMode(handle: int) -> int: ... | |||
| def SetConsoleMode(handle: int, mode: int) -> None: ... | |||
There was a problem hiding this comment.
Can you temporarily delete these methods and then add them back? I would like to make sure that the CI fails when these are missing.
There was a problem hiding this comment.
There you go, fails on windows now :)
…into colorama-windows
This reverts commit 1cf0f57.
Akuli
approved these changes
Nov 12, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the stubs that benefit from #8923
In fact, stubtest found 2 missing methods on windows!