Fix a few issues with parameter defaults #9572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't changed any of the more opinionated ones disallowed by PyCQA/flake8-pyi#336, such as a few integer defaults which are simply very big numbers -- I figured we should let the discussion on that PR finish first :) |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| @@ -37,9 +37,7 @@ def java_ver( | |||
| release: str = "", vendor: str = "", vminfo: tuple[str, str, str] = ..., osinfo: tuple[str, str, str] = ... | |||
| ) -> tuple[str, str, tuple[str, str, str], tuple[str, str, str]]: ... | |||
| def system_alias(system: str, release: str, version: str) -> tuple[str, str, str]: ... | |||
| def architecture( | |||
There was a problem hiding this comment.
part of me wants to keep this as an easter egg
JelleZijlstra
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these vary depending on the machine you're running on (the ones in
sysconfig.pyi,platform.pyi,ctypes/__init__.pyi,multiprocessing/heap.pyi,pydoc.pyi). We might be able to give slightly better defaults for some of these if PyCQA/flake8-pyi#336 (or something like it) is merged.Some others currently have integer defaults in the stub, but enum defaults at runtime, causing stubtest to complain if you use mypy
master(the ones inssl.pyi,socket.pyi,asyncore.pyi).The
email.parserones just need some method overrides in the stub that weren't necessary before we added default values.Refs #8988 (comment), and following comments.