Add defaults for params and constants in pyinstaller #9640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Avasam
commented
Jan 31, 2023
•
Avasam
commented
- Ran https://github.com/JelleZijlstra/stubdefaulter
- Manually added default kwarg parameters
- Manually added defaults and Final for constants
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Avasam
commented
Jan 31, 2023
| DEFAULT_DISTPATH: str | ||
| DEFAULT_WORKPATH: str | ||
| PLATFORM: LiteralString | ||
| __version__: Final[str] |
There was a problem hiding this comment.
Given the special meaning of __version__, I feel like it should always be considered constant/final. Maybe a project-wide search&replace for ^__version__: str$ --> __version__: Final[str] could have value?
Avasam
changed the title
JelleZijlstra
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.