Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated to typing_extensions #9850

Merged

Conversation

FasterSpeeding
Copy link
Contributor

This is included in typing_extensions as of v4.5.0 (which came out on the 15th of Feb)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Diff from mypy_primer, showing the effect of this PR on open source code:

Tanjun (https://github.com/FasterSpeeding/Tanjun)
- tanjun/conversion.py:123: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:123: error: Untyped decorator makes function "async_caches" untyped  [misc]
- tanjun/conversion.py:129: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:129: error: Untyped decorator makes function "cache_components" untyped  [misc]
- tanjun/conversion.py:152: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:152: error: Untyped decorator makes function "intents" untyped  [misc]
- tanjun/conversion.py:390: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:454: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:508: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:557: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:602: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:675: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:732: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:784: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:839: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/conversion.py:951: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/parsing.py:478: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/clients.py:1342: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/clients.py:1342: error: Untyped decorator makes function "set_global_commands" untyped  [misc]
- tanjun/annotations.py:524: error: Module has no attribute "deprecated"  [attr-defined]
- tanjun/annotations.py:524: error: Untyped decorator makes function "default" untyped  [misc]

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for missing this.

@JelleZijlstra JelleZijlstra merged commit 81f2f22 into python:main Mar 6, 2023
@FasterSpeeding FasterSpeeding deleted the typing-extensions-deprecated branch March 6, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants