Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 in typing_extensions #1006

Closed
wants to merge 13 commits into from

Conversation

AA-Turner
Copy link
Member

Python 3.6 is now end of life (python/peps@58b93bd)

This drops support and does various cleanup things (see commits for more detail).

Hopefully this would make e.g. #963 easier (xref #963 (comment))

A

@AA-Turner AA-Turner changed the title Drop Python 3.6 Drop Python 3.6 in typing_extensions Jan 4, 2022
@srittau
Copy link
Collaborator

srittau commented Jan 4, 2022

+1 from me, but I know some people are in favor of supporting 3.6 for a while longer. On the other hand, typing-extensions 4 is still available.

@hauntsaninja
Copy link
Collaborator

Is PEP 646 the only thing that will be included in the short-term future? If so, +1 from me. If not, might be nice to get those in, although as srittau says, we could always backport (but that's a hassle).

@JelleZijlstra
Copy link
Member

The only other thing that is on the horizon right now is dataclass_transform I believe. (There are also pending PEPs for Literal[str] and callable syntax, but those shouldn't affect typing-extensions. We already support Self.) But dataclass_transform will mostly be a stub-only thing, so it doesn't seem too important to support at runtime in typing-extensions.

@srittau
Copy link
Collaborator

srittau commented Jan 9, 2022

A minor wish: Could we split the changes to the workflow file (except for dropping 3.6) out into a separate PR for a cleaner history?

@AA-Turner
Copy link
Member Author

Only dropping 3.6 remains in this PR, see #1017

A

# Conflicts:
#	.github/workflows/ci.yml
@JelleZijlstra
Copy link
Member

I'd like to do one more release (4.1.0) with 3.6 support for the PEP 646 objects. After that we can drop 3.6. It should not require a major version change though, it can just be 4.2.0.

@AA-Turner
Copy link
Member Author

Updated the version number to 4.2.0 -- I can merge in master now to resolve conflicts, or wait until PEP 646 support &c has been released in v4.1.0. Which would you prefer?

A

@JelleZijlstra
Copy link
Member

Thanks! I'd suggest to defer dealing with the merge conflicts until we're ready, because you'll just get new ones if there are any additional changes.

@srittau srittau marked this pull request as draft February 2, 2022 11:28
@srittau
Copy link
Collaborator

srittau commented Feb 2, 2022

Converted to draft to signal that we are "waiting for stuff". Please unconvert once 4.1.0 has been released.

JelleZijlstra added a commit to JelleZijlstra/typing that referenced this pull request Mar 17, 2022
This replaces python#1006, which has a lot of merge conflicts that seemed
difficult to resolve. This PR aims to be simpler.
@srittau
Copy link
Collaborator

srittau commented Mar 17, 2022

Superceded by #1104. Thanks!

@srittau srittau closed this Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants