-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.6 in typing_extensions
#1006
Conversation
typing_extensions
- Inline test helpers - Merge GetTypeHintTests and GetTypeHintsTests - Remove rogue exec call - Remove check given 3.10 has been released
+1 from me, but I know some people are in favor of supporting 3.6 for a while longer. On the other hand, typing-extensions 4 is still available. |
Is PEP 646 the only thing that will be included in the short-term future? If so, +1 from me. If not, might be nice to get those in, although as srittau says, we could always backport (but that's a hassle). |
The only other thing that is on the horizon right now is |
A minor wish: Could we split the changes to the workflow file (except for dropping 3.6) out into a separate PR for a cleaner history? |
Only dropping 3.6 remains in this PR, see #1017 A |
# Conflicts: # .github/workflows/ci.yml
I'd like to do one more release (4.1.0) with 3.6 support for the PEP 646 objects. After that we can drop 3.6. It should not require a major version change though, it can just be 4.2.0. |
Updated the version number to 4.2.0 -- I can merge in master now to resolve conflicts, or wait until PEP 646 support &c has been released in v4.1.0. Which would you prefer? A |
Thanks! I'd suggest to defer dealing with the merge conflicts until we're ready, because you'll just get new ones if there are any additional changes. |
Converted to draft to signal that we are "waiting for stuff". Please unconvert once 4.1.0 has been released. |
This replaces python#1006, which has a lot of merge conflicts that seemed difficult to resolve. This PR aims to be simpler.
Superceded by #1104. Thanks! |
Python 3.6 is now end of life (python/peps@58b93bd)
This drops support and does various cleanup things (see commits for more detail).
Hopefully this would make e.g. #963 easier (xref #963 (comment))
A