Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made proposed change to the typing spec with regard to NoReturn and… #1570

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Made proposed change to the typing spec with regard to NoReturn and… #1570

merged 1 commit into from
Jan 12, 2024

Conversation

erictraut
Copy link
Collaborator

… where it can be used.

@erictraut erictraut mentioned this pull request Jan 10, 2024
Closed
sobolevn
sobolevn approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I have many existing use-cases for NoReturn in different contexts. I think that making it not-the-same-as Never is aсtually an unneeded complexity.

hauntsaninja
hauntsaninja approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The phrasing might be read as implying some sort of stylistic preference, curious if that was intentional

@erictraut
Copy link
Collaborator Author

The phrasing might be read as implying some sort of stylistic preference, curious if that was intentional

Not really. The intention was to try to give some background explanation for why there are two ways to spell the same type — and where each has typically been used. If you have a suggestion for how to improve the wording, let me know.

@JelleZijlstra JelleZijlstra merged commit 071c685 into python:main Jan 12, 2024
3 checks passed
@JelleZijlstra
Copy link
Member

Merged as this has been approved by all Council members. I think the wording is fine, but we can tweak it in a follow-up PR if desired.

@JelleZijlstra JelleZijlstra mentioned this pull request Apr 6, 2024
Merged
@erictraut erictraut deleted the no_return branch April 14, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@sobolevn sobolevn sobolevn approved these changes

@rchen152 rchen152 rchen152 approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erictraut @JelleZijlstra @gvanrossum @rchen152 @sobolevn @hauntsaninja