Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: Add "meta" file describing process for changing the spec #1573

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

JelleZijlstra
Copy link
Member

I think this isn't currently very clearly documented. Hopefully this
will be a good place to find it.

I think this isn't currently very clearly documented. Hopefully this
will be a good place to find it.
@JelleZijlstra JelleZijlstra added the Typing Council decision Needs to be approved by the Typing Council. Do not merge until approved. label Jan 11, 2024
Comment on lines 21 to 30
- Minor, non-substantive changes can simply be proposed as PRs to
the `python/typing <https://github.com/python/typing>`__ repository,
and may be merged by anyone with commit access. Such changes may
include formatting fixes, linking improvements, etc.
- Major changes should go through the PEP process, as described in
:pep:`1`. What counts as a major change is not precisely defined,
but it would generally include any change of a similar magnitude
to `previous typing PEPs <https://peps.python.org/topic/typing/>`__.
- Substantive changes that do not rise to the level of a PEP must
be approved by the Typing Council. The procedure is described below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering here is a bit weird -- it feels like counting 1, 3, 2.

I noticed because there's a gray area between minor and substantive where the TC needs to approve but no conformance test suite changes are needed (e.g. because we're merely confirming that what happens to work is in fact meant to work rather than undefined behavior where the current crop of checkers all happen to agree).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I will reorder the list. (I had a reason for this order but it's not worth the confusion.)

@hauntsaninja hauntsaninja merged commit 46d7064 into python:main Jan 12, 2024
3 checks passed
@hugovk hugovk mentioned this pull request Jan 12, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing Council decision Needs to be approved by the Typing Council. Do not merge until approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants