Fixed a few bugs in the conformance tests: #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated comments in `protocols_explicit` to clarify that error must be generated at class instantiation time rather than class declaration time. Updated pyright results to indicate that it does not pass this test. * Fixed a couple of bugs in the `generics_typevartuple_specialization` test that caused the test not to properly test what it was intended to test. * Added a missing test to the `generics_typevartuple_callable` test. * Fixed a bug in the `generics_typevartuple_basic` test that caused the test not to properly test what was intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protocols_explicitto clarify that error must be generated at class instantiation time rather than class declaration time. Updated pyright results to indicate that it does not pass this test.generics_typevartuple_specializationtest that caused the test not to properly test what it was intended to test.generics_typevartuple_callabletest.generics_typevartuple_basictest that caused the test not to properly test what was intended.