Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded "Callables" chapter to include additional details. #1723

Merged
merged 10 commits into from
May 5, 2024

Conversation

erictraut
Copy link
Collaborator

No description provided.

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! A few minor comments.

docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
erictraut and others added 6 commits April 21, 2024 00:48
Co-authored-by: David Salvisberg <dave@daverball.com>
Co-authored-by: David Salvisberg <dave@daverball.com>
…into callables_spec2

# Conflicts:
#	docs/spec/callables.rst
…f` statement should be interpreted as `...`. Clarified that `...` can be used with `Concatenate` and explained how this is interpreted.
docs/spec/callables.rst Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Show resolved Hide resolved
erictraut and others added 2 commits May 4, 2024 14:16
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Here are some editorial nits -- take them or leave them. I will check the box in the issue as well.

docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
docs/spec/callables.rst Outdated Show resolved Hide resolved
@erictraut
Copy link
Collaborator Author

Thanks for the review @gvanrossum. I incorporated all of your suggested changes.

@erictraut erictraut marked this pull request as ready for review May 5, 2024 21:58
@erictraut erictraut merged commit e4643cb into python:main May 5, 2024
5 checks passed
@erictraut erictraut deleted the callables_spec2 branch May 5, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants