Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore reveal_type errors when parsing Pyre output #1832

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

yangdanny97
Copy link
Contributor

Pyre generates diagnostics for reveal_type like any other type error, since it doesn't distinguish between errors and warnings in the output.

The mypy and pyright reveal_type diagnostics are prefixed with note and info, which get filtered out when parsing the output. This PR updates Pyre's output parsing to ignore reveal_type errors. They'll still show up in the output, but they will no longer cause "unexpected error" conformance mismatches that need to be manually checked.

@JelleZijlstra JelleZijlstra merged commit 0b4e1aa into python:main Aug 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants