Ignore reveal_type errors when parsing Pyre output #1832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyre generates diagnostics for
reveal_type
like any other type error, since it doesn't distinguish between errors and warnings in the output.The mypy and pyright
reveal_type
diagnostics are prefixed withnote
andinfo
, which get filtered out when parsing the output. This PR updates Pyre's output parsing to ignorereveal_type
errors. They'll still show up in the output, but they will no longer cause "unexpected error" conformance mismatches that need to be manually checked.