Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PEP 705 #284

Merged
merged 9 commits into from
Nov 29, 2023
Merged

Add support for PEP 705 #284

merged 9 commits into from
Nov 29, 2023

Conversation

JelleZijlstra
Copy link
Member

No description provided.

@JelleZijlstra
Copy link
Member Author

Let's not merge this until python/peps#3440 is merged.

@JelleZijlstra JelleZijlstra mentioned this pull request Sep 18, 2023
Merged
4 tasks
srittau
srittau reviewed Sep 18, 2023
View reviewed changes
doc/index.rst Outdated Show resolved Hide resolved
alicederyn
alicederyn reviewed Sep 19, 2023
View reviewed changes
doc/index.rst Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood reviewed Sep 19, 2023
View reviewed changes
src/typing_extensions.py Outdated Show resolved Hide resolved
src/typing_extensions.py Outdated Show resolved Hide resolved
src/typing_extensions.py Outdated Show resolved Hide resolved
@alicederyn
Copy link
Contributor

alicederyn commented Nov 28, 2023 •
edited
Loading

PEP-705 has dropped both readonly and other_keys flags; only the typing.ReadOnly annotation needs to be added now.

@JelleZijlstra JelleZijlstra mentioned this pull request Nov 29, 2023
Closed
@JelleZijlstra @alicederyn
Apply suggestions from code review
e865252 
Co-authored-by: Alice <Alice.Purcell.39@gmail.com>
AlexWaygood
AlexWaygood approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions (mostly optional), but overall this looks good!

src/test_typing_extensions.py Outdated Show resolved Hide resolved
src/typing_extensions.py Outdated Show resolved Hide resolved
src/typing_extensions.py Show resolved Hide resolved
src/typing_extensions.py Show resolved Hide resolved
JelleZijlstra and others added 2 commits November 29, 2023 09:39
@JelleZijlstra @AlexWaygood
Update src/test_typing_extensions.py
597c07a 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstra @AlexWaygood
Apply suggestions from code review
deb966d 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JelleZijlstra JelleZijlstra merged commit 0b0166d into python:main Nov 29, 2023
18 checks passed
@JelleZijlstra JelleZijlstra deleted the pep705 branch November 29, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicederyn alicederyn alicederyn left review comments

@srittau srittau srittau left review comments

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JelleZijlstra @alicederyn @srittau @AlexWaygood