-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow for Trusted Publishing #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this is ready to merge now, if someone wants to approve again. |
python -m pip install --user $path_to_file | ||
python -m pip list | ||
- name: Run typing_extensions tests against installed package | ||
run: rm src/typing_extensions.py && python src/test_typing_extensions.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an idea: To make it more robust against future changes, maybe copy the test_*
script to /tmp
and delete all of src
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not enough because it relies on a few helper files. I think we'll have to change this either way if we ever change our file layout.
python -m pip install --user $path_to_file | ||
python -m pip list | ||
- name: Run typing_extensions tests against installed package | ||
run: rm src/typing_extensions.py && python src/test_typing_extensions.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above.
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
No description provided.