replace access token after revoke #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After calling revoke_access_token(), access_token revokes and new access_token must be replace.
replace new access token
python273
reviewed
Oct 3, 2018
telegraph/api.py
Outdated
| response = self._telegraph.method('revokeAccessToken') | ||
|
|
||
| if replace_token: | ||
| self._telegraph.access_token = response.get('access_token') |
There was a problem hiding this comment.
hmm, I think replace_token arg is not really needed here
There was a problem hiding this comment.
If you agree with replacing access_token, replacing can be automated.
There was a problem hiding this comment.
Yeah, I think we can just replace current token, since it gets invalid anyway
Now, After revoke, new access_token replaced.
python273
reviewed
Oct 3, 2018
telegraph/api.py
Outdated
| response = self._telegraph.method('revokeAccessToken') | ||
|
|
||
| self._telegraph.access_token = response.get('access_token') | ||
|
|
There was a problem hiding this comment.
Can you also remove spaces from blank lines?
|
👍 |
|
Thanks for this simple and great wrapper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After calling revoke_access_token(), access_token revokes and new access_token must be replace.