Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0.0 #57

Closed
wants to merge 4 commits into from
Closed

Conversation

Sasivarnasarma
Copy link

Version 3.0.0

With ❤️ By @Sasivarnasarma

A proper and best asynchronous script. (Not Auto generated)
Proper naming for scripts and classes.
For both sync and async, just httpx is sufficient as a prerequisite.
Use telegraph.close() to properly close the httpx client.
Capable of acting as Context Manager to properly close the httpx client.
New Sync and Async function to upload files.
Simple way to import required classes.

With ❤️ By @Sasivarnasarma
New Examples.
Added Credits.
Issues python273#56 , python273#55 , python273#47 Fixed.
Added New Exception.
 __init__ file improved.
Change api and async_api file to private.
@python273
Copy link
Owner

There's a lot of repos depending on the lib, so changing naming/dependencies without a good reason is a bad idea. Very likely only bugfixes and additions to API will be merged, so I don't see useful changes in PR.

And generally I don't recommend sending PRs with tons of changes without discussing it first.

Use telegraph.close() to properly close the httpx client.

There was annoying warning in httpx on process exit, but I think they removed it at some point, so it's not needed.

@python273 python273 closed this Apr 6, 2024
@Sasivarnasarma
Copy link
Author

There's a lot of repos depending on the lib, so changing naming/dependencies without a good reason is a bad idea.

They can still use this with telegraph=2.2.0 Version.

only bugfixes and additions to API will be merged

Json decode error fixed

There was annoying warning in httpx on process exit, but I think they removed it at some point, so it's not needed.

Yes but we need to close httpx properly.

I don't see useful changes in PR

This PR make this repo more professional python library. Like other professional library such as bs4, httpx.
and only httpx is sufficient as a prerequisite

And if you don't want to update no problem. I can't understand why you don't like this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants