Skip to content

#1479 Fix for error during camera shake example. #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2023
Merged

#1479 Fix for error during camera shake example. #1485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion arcade/camera.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ def shake(self, velocity: Vec2, speed: float = 1.5, damping: float = 0.9):
"""
Add a camera shake.

:param Vec2 velocity: Vector to start moving the camera
:param Vec2 velocity: Vector to start moving the camera. Needs to be
a pyglet.math.Vec2.
:param float speed: How fast to shake
:param float damping: How fast to stop shaking
"""
Expand Down
5 changes: 3 additions & 2 deletions arcade/examples/sprite_move_scrolling_shake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import random
import math
import arcade
from pyglet.math import Vec2

SPRITE_SCALING = 0.5

Expand Down Expand Up @@ -157,7 +158,7 @@ def on_update(self, delta_time):
# How 'far' to shake
shake_amplitude = 10
# Calculate a vector based on that
shake_vector = (
shake_vector = Vec2(
math.cos(shake_direction) * shake_amplitude,
math.sin(shake_direction) * shake_amplitude
)
Expand All @@ -179,7 +180,7 @@ def scroll_to_player(self):
pan.
"""

position = (
position = Vec2(
self.player_sprite.center_x - self.width / 2,
self.player_sprite.center_y - self.height / 2
)
Expand Down