Skip to content

Add support for controllers with button triggers rather than axis triggers #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Add support for controllers with button triggers rather than axis triggers #2461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c4c1e4
remove trailing whitespace
DragonMoffon Nov 15, 2024
0fa8d3f
Add triggers to controller buttons because old controllers don't use …
DragonMoffon Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions arcade/camera/camera_2d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,8 +484,8 @@ def point_in_view(self, point: Point2) -> bool:
"""
# This is unwrapped from standard Vec2 operations,
# The construction and garbage collection of the vectors would
# increase this method's cost by ~4x
# increase this method's cost by ~4x

pos = self.position
diff = point[0] - pos[0], point[1] - pos[1]

Expand Down
8 changes: 6 additions & 2 deletions arcade/future/input/inputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ class ControllerButtons(StrEnum):
BOTTOM_FACE = "a"
LEFT_SHOULDER = "leftshoulder"
RIGHT_SHOULDER = "rightshoulder"
LEFT_TRIGGER = "lefttrigger"
RIGHT_TRIGGER = "righttrigger"
START = "start"
BACK = "back"
GUIDE = "guide"
Expand Down Expand Up @@ -101,11 +103,13 @@ class PSControllerButtons(StrEnum):
CROSS = ControllerButtons.BOTTOM_FACE
L1 = ControllerButtons.LEFT_SHOULDER
R1 = ControllerButtons.RIGHT_SHOULDER
L2 = ControllerButtons.LEFT_TRIGGER
R2 = ControllerButtons.RIGHT_TRIGGER
L3 = ControllerButtons.LEFT_STICK
R3 = ControllerButtons.RIGHT_STICK
START = ControllerButtons.START
SELECT = ControllerButtons.BACK
GUIDE = ControllerButtons.GUIDE
LEFT_STICK = ControllerButtons.LEFT_STICK
RIGHT_STICK = ControllerButtons.RIGHT_STICK
DPAD_LEFT = ControllerButtons.DPAD_LEFT
DPAD_RIGHT = ControllerButtons.DPAD_RIGHT
DPAD_UP = ControllerButtons.DPAD_UP
Expand Down
Loading