Skip to content

Fix multiline string properties #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fix multiline string properties #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ede615
Test for multiline object properties.
KockaAdmiralac Aug 23, 2024
356723c
Fix parsing of multiline string properties.
KockaAdmiralac Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pytiled_parser/parsers/tmx/properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@ def parse(raw_properties: etree.Element) -> Properties:
for raw_property in raw_properties.findall("property"):
type_ = raw_property.attrib.get("type")

if "value" not in raw_property.attrib:
value_ = raw_property.attrib.get("value", raw_property.text)
if value_ is None:
continue

value_ = raw_property.attrib["value"]

if type_ == "file":
value = Path(value_)
elif type_ == "color":
Expand Down
4 changes: 4 additions & 0 deletions tests/test_tiled_object_tmx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@
<property name="float property" type="float" value="42.1"/>
<property name="int property" type="int" value="8675309"/>
<property name="string property" value="pytiled_parser rulez!1!!"/>
<property name="multiline string property">Hi
I can write multiple lines in here
That's pretty great</property>
</properties>
</object>
""",
Expand All @@ -144,6 +147,7 @@
"float property": 42.1,
"int property": 8675309,
"string property": "pytiled_parser rulez!1!!",
"multiline string property": "Hi\nI can write multiple lines in here\nThat's pretty great",
},
),
),
Expand Down