Fix python_requires to valid PEP 440 syntax #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jborean93
force-pushed
the
python-requires
branch
from
0f2d5c9
to
00d4342
Compare
jborean93
changed the title
Signed-off-by: Jordan Borean <jborean93@gmail.com>
jborean93
force-pushed
the
python-requires
branch
from
00d4342
to
5855746
Compare
frozencemetery
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in python-poetry/poetry#4201 the existing
python_requiresvalid of>=3.6.*is invalid and should be>=3.6. PEP440 only states that the wildcard suffix is used with version matching==. The ordered sections do not state it allows the same rules as==unlike the section for!=does.This still seems to work fine with
pipluckily but tools likepoetryseem to be a bit more strict in the intepretation and the upcoming version will error if they encounter this syntax python-poetry/poetry#4201.