Gets the name of the sheet from the workbook.xml.rels file #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonicrubyist
added a commit
that referenced
this pull request
Oct 18, 2015
Gets the name of the sheet from the workbook.xml.rels file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creek currently just saves the order of the declaration of the tags as an index and uses that to get the sheet xml file.
While it is true that the order will usually be the same as the number on the ids and the number of the sheet, it is not strictly true. If the sheets are rearranged after creation and also depending on the tool used to generate the .xlsx file, they can come out in strange orders.
This should make sure it will find the right sheet by going to workbook.xml.rels and matching the r:id in the worksheet relationships to find the corresponding sheet path.
Fixes #19