Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

의존성 추가: django-constance #24

Merged
merged 9 commits into from
Feb 24, 2023

Conversation

golony6449
Copy link
Member

목표

  • 설정값 관리를 위한 저장소가 필요합니다. (Slack 알림 채널, Secret 등)

작업내용

  • django-constance를 의존성에 추가합니다.

유의사항

  • 리뷰어는 PyConKR-2023을 지정 해 주세요.
  • 작업한 내용을 상세하게 작성해주세요.

@golony6449 golony6449 requested a review from a team February 22, 2023 15:49
@golony6449 golony6449 self-assigned this Feb 22, 2023
@@ -130,3 +132,16 @@
# django-summernote
MEDIA_URL = "/media/"
MEDIA_ROOT = os.path.join(BASE_DIR, "media/")

# django-constance
CONSTANCE_BACKEND = 'constance.backends.database.DatabaseBackend'
Copy link
Contributor

@pers0n4 pers0n4 Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분이 single quote네요

Suggested change
CONSTANCE_BACKEND = 'constance.backends.database.DatabaseBackend'
CONSTANCE_BACKEND = "constance.backends.database.DatabaseBackend"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pers0n4 감사합니다 :-)

@golony6449 golony6449 merged commit e5fdf73 into pythonkr:devdev Feb 24, 2023
@golony6449 golony6449 deleted the feature/golony/add-dep branch February 24, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants